Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: v4->v5 only #1782

Merged
merged 6 commits into from
Jul 27, 2022
Merged

chore: v4->v5 only #1782

merged 6 commits into from
Jul 27, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jul 26, 2022

Description

This PR only changes module paths from v4 to v5.

It'll make #1653 much easier to review.

Closes #1780


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@chatton
Copy link
Contributor

chatton commented Jul 26, 2022

Hi @faddat thanks for this, it's looking great!

Can we leave everything under the e2e directory at v4 though? For the same reason outlined in the other PR.

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2022

Codecov Report

Merging #1782 (32426ca) into main (8987888) will increase coverage by 0.02%.
The diff coverage is 92.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1782      +/-   ##
==========================================
+ Coverage   80.05%   80.08%   +0.02%     
==========================================
  Files         164      165       +1     
  Lines       12300    12351      +51     
==========================================
+ Hits         9847     9891      +44     
- Misses       1993     1997       +4     
- Partials      460      463       +3     
Impacted Files Coverage Δ
...7-interchain-accounts/controller/ibc_middleware.go 84.48% <ø> (ø)
...7-interchain-accounts/controller/keeper/account.go 77.77% <ø> (ø)
...27-interchain-accounts/controller/keeper/events.go 0.00% <ø> (ø)
...7-interchain-accounts/controller/keeper/genesis.go 90.00% <ø> (ø)
...nterchain-accounts/controller/keeper/grpc_query.go 100.00% <ø> (ø)
...interchain-accounts/controller/keeper/handshake.go 87.87% <ø> (ø)
...27-interchain-accounts/controller/keeper/keeper.go 94.73% <ø> (ø)
...27-interchain-accounts/controller/keeper/params.go 100.00% <ø> (ø)
.../27-interchain-accounts/controller/keeper/relay.go 78.04% <ø> (ø)
...les/apps/27-interchain-accounts/host/ibc_module.go 95.00% <ø> (ø)
... and 103 more

@faddat
Copy link
Contributor Author

faddat commented Jul 26, 2022

yep, I was wondering about that. Fixing :)

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @faddat, much appreciated! ❤️

Could you update the protobuf go_package option also to reflect the v5 module naming? You can run make proto-all to regenerate the .pb.go files with the appropriate import path then!

@faddat
Copy link
Contributor Author

faddat commented Jul 26, 2022

fixing the fix...

@faddat
Copy link
Contributor Author

faddat commented Jul 26, 2022

so, I think there's something wrong with make proto-gen

new .pb.go files are being made but not being used.

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, @faddat!

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@colin-axner colin-axner enabled auto-merge (squash) July 27, 2022 11:21
@colin-axner colin-axner merged commit af4e651 into cosmos:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump package to v5
7 participants