-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: v4->v5 only #1782
chore: v4->v5 only #1782
Conversation
Hi @faddat thanks for this, it's looking great! Can we leave everything under the |
yep, I was wondering about that. Fixing :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @faddat, much appreciated! ❤️
Could you update the protobuf go_package
option also to reflect the v5
module naming? You can run make proto-all
to regenerate the .pb.go
files with the appropriate import path then!
fixing the fix... |
so, I think there's something wrong with make proto-gen new .pb.go files are being made but not being used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much, @faddat!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
This PR only changes module paths from v4 to v5.
It'll make #1653 much easier to review.
Closes #1780
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes