feat(test): adding test to verify invalid recipient address over incentivized channel #1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
seantking,
charleenfei and
damiannolan
as code owners
…ccount-ibc-transaction-fails
…ccount-ibc-transaction-fails
colin-axner
approved these changes
Aug 11, 2022
e2e/fee_middleware_test.go
Outdated
|
|
||
| _, chainBRelayerUser := s.GetRelayerUsers(ctx) | ||
|
|
||
| t.Run("register counter party payee", func(t *testing.T) { |
There was a problem hiding this comment.
Suggested change
| t.Run("register counter party payee", func(t *testing.T) { | |
| t.Run("register counterparty payee", func(t *testing.T) { |
We reference counterparty as one word throughout the codebase
There was a problem hiding this comment.
I updated other occurrences of this as well.
e2e/fee_middleware_test.go
Outdated
| transferAmount := testvalues.DefaultTransferAmount(chainADenom) | ||
|
|
||
| t.Run("send IBC transfer", func(t *testing.T) { | ||
| transferMsg := transfertypes.NewMsgTransfer(channelA.PortID, channelA.ChannelID, transferAmount, chainAWallet.Bech32Address(chainA.Config().Bech32Prefix), testvalues.InvalidAddress, s.GetTimeoutHeight(ctx, chainA), 0) |
There was a problem hiding this comment.
Suggested change
| transferMsg := transfertypes.NewMsgTransfer(channelA.PortID, channelA.ChannelID, transferAmount, chainAWallet.Bech32Address(chainA.Config().Bech32Prefix), testvalues.InvalidAddress, s.GetTimeoutHeight(ctx, chainA), 0) | |
| transferMsg := transfertypes.NewMsgTransfer(channelA.PortID, channelA.ChannelID, transferAmount, chainAWallet.Bech32Address(chainA.Config().Bech32Prefix), testvalues.InvalidAddress, s.GetTimeoutHeight(ctx, chainB), 0) |
I was a bit worried about this not being clear, but the timeout function returns a valid timeout for the chain referenced. When sending packets, the timeout is for the chain receiving the packet. So if you send from chainA, you want the timeout from chainB
There was a problem hiding this comment.
ah I see, thanks for the clarification. I'll make this change.
…ccount-ibc-transaction-fails
crodriguezvega
approved these changes
Aug 12, 2022
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
…ccount-ibc-transaction-fails
chatton
deleted the
cian/issue#1967-e2e-fee-middleware-invalid-account-ibc-transaction-fails
branch
3 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #1967
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes