Missing NextClientSequence, NextConnectionSequence and NextChannelSequence in ExportGenesis #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allthatjazzleo
requested review from
AdityaSripal,
colin-axner and
fedekunze
as code owners
4 tasks
colin-axner
approved these changes
May 27, 2021
There was a problem hiding this comment.
Very nice catch! Thank you!!
Our genesis testing is certainly lacking. It was previously thought that genesis restarts would be an unsupported upgrade path for IBC, but it was fairly recently noted in #21 that we can support genesis restarts (especially when it isn't a zero height restart)
|
I will backport this. Thanks again! |
9 tasks
faddat
referenced
this pull request
in notional-labs/ibc-go
Feb 23, 2022
Follow sdk amino naming convention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #199
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes