Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete queries generated from the removed QueryAppVersionRequest/QueryAppVersionResponse #2045

Merged
merged 10 commits into from
Aug 23, 2022

Conversation

crodriguezvega
Copy link
Contributor

Description

Removes left over code from the deletion of port/v1/query here.

closes: #1868


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@crodriguezvega crodriguezvega linked an issue Aug 18, 2022 that may be closed by this pull request
3 tasks
Copy link
Contributor

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, nice catch!

@crodriguezvega crodriguezvega merged commit 6203380 into main Aug 23, 2022
@crodriguezvega crodriguezvega deleted the carlos/issue#1868-remove-outdated-queries branch August 23, 2022 10:38
ulbqb pushed a commit to ulbqb/ibc-go that referenced this pull request Apr 19, 2023
…ueryAppVersionResponse` (cosmos#2045)

* delete unused code

* remove RegisterQueryService

* remove unused import
ulbqb added a commit to Finschia/ibc-go that referenced this pull request Apr 19, 2023
…t`/`QueryAppVersionResponse` (#11)

* delete queries generated from the removed `QueryAppVersionRequest`/`QueryAppVersionResponse` (cosmos#2045)

* delete unused code

* remove RegisterQueryService

* remove unused import

* Update CHANGELOG.md

---------

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove outdated queries
4 participants