chore: adding sdk.Msg impl for ics27 MsgSubmitTx (backport #2135) #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* add protos/rpcs, boilerplate (cherry picked from commit 41d69d8)
mergify
bot
requested review from
seantking,
colin-axner,
AdityaSripal,
damiannolan,
crodriguezvega,
charleenfei and
chatton
as code owners
colin-axner
approved these changes
Sep 7, 2022
damiannolan
reviewed
Sep 7, 2022
| @@ -6,5 +6,5 @@ import ( | |||
|
|
|||
| // ICA Controller sentinel errors | |||
| var ( | |||
| ErrControllerSubModuleDisabled = sdkerrors.Register(SubModuleName, 2, "controller submodule is disabled") | |||
| ErrControllerSubModuleDisabled = sdkerrors.Register(SubModuleName, 1, "controller submodule is disabled") | |||
There was a problem hiding this comment.
Any ideas why this was changed? Isn't 1 reserved? See: https://github.com/cosmos/cosmos-sdk/blob/main/errors/errors.go#L17
Not sure if that's the exact codespace where 1 is taken, but looking at all of our errors.go files in ibc-go we usually start at 2
cc. @colin-axner
There was a problem hiding this comment.
yea that's a bug. 1 is reserved for sdk, it'll discard our error messages otherwise
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2135 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com