ensure latest height revision number matches chain id revision number #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix tests as well
colin-axner
commented
Jul 7, 2021
colin-axner
commented
Jul 7, 2021
AdityaSripal
requested changes
Jul 7, 2021
Comment on lines
126
to
132
| return sdkerrors.Wrapf(ErrInvalidHeaderHeight, "tendermint revision height cannot be zero") | ||
| return sdkerrors.Wrapf(ErrInvalidHeaderHeight, "latest height revision height cannot be zero") |
There was a problem hiding this comment.
I would say this should remain. No tendermint height should start at 0
There was a problem hiding this comment.
I can add back the tendermint part but the latest height makes things more specific since the frozen height also contains a revision height
| @@ -657,7 +657,7 @@ func (suite *KeeperTestSuite) TestUpgradeClient() { | |||
| name: "successful upgrade", | |||
| setup: func() { | |||
|
|
|||
| upgradedClient = ibctmtypes.NewClientState("newChainId", ibctmtypes.DefaultTrustLevel, ibctesting.TrustingPeriod, ibctesting.UnbondingPeriod+ibctesting.TrustingPeriod, ibctesting.MaxClockDrift, newClientHeight, commitmenttypes.GetSDKSpecs(), ibctesting.UpgradePath, false, false) | |||
| upgradedClient = ibctmtypes.NewClientState("newChainId-1", ibctmtypes.DefaultTrustLevel, ibctesting.TrustingPeriod, ibctesting.UnbondingPeriod+ibctesting.TrustingPeriod, ibctesting.MaxClockDrift, newClientHeight, commitmenttypes.GetSDKSpecs(), ibctesting.UpgradePath, false, false) | |||
There was a problem hiding this comment.
Why don't you create the variable for these tests as well?
There was a problem hiding this comment.
sure, there was only 2 of them so didn't feel as necessary
AdityaSripal
approved these changes
Jul 7, 2021
colin-axner
added a commit
that referenced
this pull request
Jul 7, 2021
…#241) * ensure latest height revision number matches chain id revision number fix tests as well * add changelog * Update modules/light-clients/07-tendermint/types/client_state_test.go * Update modules/light-clients/07-tendermint/types/client_state_test.go * address review suggestions
colin-axner
added a commit
that referenced
this pull request
Jul 7, 2021
* Fix/channel open/close events (#220) * fix: moving event to keeper function instead of rpc handler * refactor: removing unnecessary handler * refactor: delete channel handler file * Apply suggestions from code review Co-authored-by: Aditya <adityasripal@gmail.com> * ibc: fix metrics (#223) * add missing changelog entries (#230) * add missing changelog entries * add missing entry * Fix missing events in OnRecvPacket (#233) * fix to set events to the original context * Update modules/core/keeper/msg_server.go Co-authored-by: Aditya <adityasripal@gmail.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * bump SDK dependency to v0.43.0-rc0 (#229) Co-authored-by: Aditya <adityasripal@gmail.com> * Sentinel Root Fix (#234) * fix sentinel value * add godoc and test * fix grammar * add changelog Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * export connection params (#242) * ensure latest height revision number matches chain id revision number (#241) * ensure latest height revision number matches chain id revision number fix tests as well * add changelog * Update modules/light-clients/07-tendermint/types/client_state_test.go * Update modules/light-clients/07-tendermint/types/client_state_test.go * address review suggestions * fix merge conflict Co-authored-by: Sean King <seantking@users.noreply.github.com> Co-authored-by: Aditya <adityasripal@gmail.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Jun Kimura <junkxdev@gmail.com>
CosmosCar
pushed a commit
to caelus-labs/ibc-go
that referenced
this pull request
Nov 6, 2023
Fill in all the missing fields of Status() ROC for compatibility with Tendermint RPC. Fixes cosmos#241.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #240
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes