Simplify SendPacket API (backport #1703) #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
## Description closes: #1395 --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer - [ ] Review `Codecov Report` in the comment section below once CI passes (cherry picked from commit 88525d2) # Conflicts: # modules/apps/29-fee/keeper/keeper.go # modules/core/04-channel/keeper/packet.go # modules/core/04-channel/keeper/packet_test.go
mergify
bot
requested review from
AdityaSripal,
seantking,
charleenfei,
colin-axner,
damiannolan,
crodriguezvega and
chatton
as code owners
|
This pull request introduces 3 alerts when merging ec3b725 into cbf86ff - view on LGTM.com new alerts:
|
|
I will fix the conflicts. |
added 2 commits
October 7, 2022 10:30
| @@ -37,7 +38,7 @@ type Keeper struct { | |||
| // NewKeeper creates a new interchain accounts controller Keeper instance | |||
| func NewKeeper( | |||
| cdc codec.BinaryCodec, key storetypes.StoreKey, paramSpace paramtypes.Subspace, | |||
| ics4Wrapper icatypes.ICS4Wrapper, channelKeeper icatypes.ChannelKeeper, portKeeper icatypes.PortKeeper, | |||
| ics4Wrapper porttypes.ICS4Wrapper, channelKeeper icatypes.ChannelKeeper, portKeeper icatypes.PortKeeper, | |||
There was a problem hiding this comment.
Note: I think we need to document this API breaking change in the migration docs as well.
There was a problem hiding this comment.
I guess we can. It shouldn't come up as an issue unless the provided module didn't entirely fulfill the ICS4Wrapper interface as defined by 05-port
| @@ -37,7 +38,7 @@ type Keeper struct { | |||
| // NewKeeper creates a new interchain accounts host Keeper instance | |||
| func NewKeeper( | |||
| cdc codec.BinaryCodec, key storetypes.StoreKey, paramSpace paramtypes.Subspace, | |||
| ics4Wrapper icatypes.ICS4Wrapper, channelKeeper icatypes.ChannelKeeper, portKeeper icatypes.PortKeeper, | |||
| ics4Wrapper porttypes.ICS4Wrapper, channelKeeper icatypes.ChannelKeeper, portKeeper icatypes.PortKeeper, | |||
There was a problem hiding this comment.
Add this change to migration docs as well.
| cdc codec.BinaryCodec, key storetypes.StoreKey, paramSpace paramtypes.Subspace, | ||
| ics4Wrapper types.ICS4Wrapper, channelKeeper types.ChannelKeeper, portKeeper types.PortKeeper, authKeeper types.AccountKeeper, bankKeeper types.BankKeeper, | ||
| cdc codec.BinaryCodec, key storetypes.StoreKey, | ||
| ics4Wrapper porttypes.ICS4Wrapper, channelKeeper types.ChannelKeeper, |
There was a problem hiding this comment.
Add to migration docs.
| @@ -31,7 +32,7 @@ type Keeper struct { | |||
| // NewKeeper creates a new IBC transfer Keeper instance | |||
| func NewKeeper( | |||
| cdc codec.BinaryCodec, key storetypes.StoreKey, paramSpace paramtypes.Subspace, | |||
| ics4Wrapper types.ICS4Wrapper, channelKeeper types.ChannelKeeper, portKeeper types.PortKeeper, | |||
| ics4Wrapper porttypes.ICS4Wrapper, channelKeeper types.ChannelKeeper, portKeeper types.PortKeeper, | |||
There was a problem hiding this comment.
Add to migration docs.
colin-axner
approved these changes
Oct 10, 2022
damiannolan
approved these changes
Oct 10, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1703 done by Mergify.
Cherry-pick of 88525d2 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com