Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip emission of unpopulated memo field in ics20 #2651

Merged
merged 5 commits into from
Nov 2, 2022
Merged

fix: skip emission of unpopulated memo field in ics20 #2651

merged 5 commits into from
Nov 2, 2022

Commits on Nov 2, 2022

  1. refactor: introduce forked function for ics20 packet data marshals 

    Copied function from https://github.com/cosmos/cosmos-sdk/blob/971c542453e0972ef1dfc5a80159ad5049c7211c/codec/json.go
Modified contents to set EmitDefaults to false, minimized code changes to avoid introducing unnecessary bugs
    @colin-axner
    colin-axner committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    4a3a355 View commit details
    Browse the repository at this point in the history

  2. add changelog entry

    @colin-axner
    colin-axner committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    74b4be0 View commit details
    Browse the repository at this point in the history

  3. go mod tidy

    @colin-axner
    colin-axner committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    527748d View commit details
    Browse the repository at this point in the history

  4. nit: fix spelling

    @colin-axner
    colin-axner committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    08679a4 View commit details
    Browse the repository at this point in the history

  5. test: add test for emitted and non-emitted memo field

    @colin-axner
    colin-axner committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    bd9921f View commit details
    Browse the repository at this point in the history