Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event tests assertion for 04-channel #2830

Closed
wants to merge 8 commits into from

Conversation

Anmol1696
Copy link
Contributor

@Anmol1696 Anmol1696 commented Nov 26, 2022

Note: Require #2829 to be ready for review

Description

Checks for events emitted for 04-channel unit tests using ibctesting.AssertEvents

part of: #2823

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@Anmol1696 Anmol1696 changed the title Anmol/event tests channel Event tests assertion for 04-channel Nov 26, 2022
@Anmol1696 Anmol1696 force-pushed the anmol/event-tests-channel branch from 756f79e to 5d0f283 Compare November 26, 2022 18:31
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2022

Codecov Report

Merging #2830 (4f17e30) into main (86332d2) will increase coverage by 0.05%.
The diff coverage is 88.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2830      +/-   ##
==========================================
+ Coverage   78.77%   78.83%   +0.05%     
==========================================
  Files         178      178              
  Lines       12261    12281      +20     
==========================================
+ Hits         9659     9682      +23     
+ Misses       2183     2180       -3     
  Partials      419      419              
Impacted Files Coverage Δ
modules/core/02-client/keeper/keeper.go 82.35% <40.00%> (-0.43%) ⬇️
modules/core/24-host/parse.go 54.09% <100.00%> (+22.39%) ⬆️
modules/core/24-host/keys.go 6.06% <0.00%> (+6.06%) ⬆️

@damiannolan
Copy link
Contributor

closing this PR as it seems stale, feel free to reopen if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants