feat: Add GetAllClientIDsOfType query function #2855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd helper key construction for client type prefix
colin-axner
commented
Nov 30, 2022
colin-axner
requested review from
AdityaSripal,
damiannolan,
crodriguezvega,
charleenfei and
chatton
as code owners
colin-axner
commented
Nov 30, 2022
| @@ -383,6 +383,28 @@ func (k Keeper) GetAllClients(ctx sdk.Context) (states []exported.ClientState) { | |||
| return states | |||
| } | |||
|
|
|||
| // GetAllClientIDsOfType will iterate over the provided client type prefix in the client store | |||
| // and return a list of clientIDs associated with the client type. | |||
| func (k Keeper) GetAllClientIDsOfType(ctx sdk.Context, clientType string) (clientIDs []string) { | |||
There was a problem hiding this comment.
This will be used in a followup pr
There was a problem hiding this comment.
I have a preference for not using named return values e.g. (clientIDs []string). I think it's more readable to be more explicit with and just declare the slice next to its usage
i.e.
var clientIDs []string
for ; iterator.Valid(); iterator.Next() {
...
clientIDs = append(clientIDs, clientID)
}WDYT?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2855 +/- ##
==========================================
- Coverage 78.32% 78.31% -0.01%
==========================================
Files 181 181
Lines 12560 12578 +18
==========================================
+ Hits 9837 9851 +14
- Misses 2285 2289 +4
Partials 438 438
|
|
@chatton and I realized it's possible to achieve the desired functionality by adding a prefix into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #2844
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.