lint tests

.golangci.yml

@@ -1,20 +1,18 @@
 run:
-  tests: false
+  tests: true
   #   # timeout for analysis, e.g. 30s, 5m, default is 1m
   timeout: 5m
 
 linters:
   disable-all: true
   enable:
-    - deadcode
     - depguard
     - dogsled
     - exportloopref
     - errcheck
     - goconst
     - gocritic
     - gofumpt
-    - goimports
     - gosec
     - gosimple
     - govet

modules/apps/27-interchain-accounts/types/codec_test.go

@@ -11,13 +11,6 @@ import (
 	"github.com/cosmos/ibc-go/v6/testing/simapp"
 )
 
-// caseRawBytes defines a helper struct, used for testing codec operations
-type caseRawBytes struct {
-	name    string
-	bz      []byte
-	expPass bool
-}
-
 // mockSdkMsg defines a mock struct, used for testing codec error scenarios
 type mockSdkMsg struct{}
 

modules/core/04-channel/types/msgs_test.go

@@ -80,7 +80,8 @@ func (suite *TypesTestSuite) SetupTest() {
 	storeKey := storetypes.NewKVStoreKey("iavlStoreKey")
 
 	store.MountStoreWithDB(storeKey, storetypes.StoreTypeIAVL, nil)
-	store.LoadVersion(0)
+	err := store.LoadVersion(0)
+	suite.Require().NoError(err)
 	iavlStore := store.GetCommitStore(storeKey).(*iavl.Store)
 
 	iavlStore.Set([]byte("KEY"), []byte("VALUE"))

modules/core/23-commitment/types/merkle_test.go

@@ -64,10 +64,10 @@ func (suite *MerkleTestSuite) TestVerifyMembership() {
 			err := proof.VerifyMembership(types.GetSDKSpecs(), &root, path, tc.value)
 
 			if tc.shouldPass {
-				// nolint: scopelint
+				//nolint: scopelint
 				suite.Require().NoError(err, "test case %d should have passed", i)
 			} else {
-				// nolint: scopelint
+				//nolint: scopelint
 				suite.Require().Error(err, "test case %d should have failed", i)
 			}
 		})
@@ -127,10 +127,10 @@ func (suite *MerkleTestSuite) TestVerifyNonMembership() {
 			err := proof.VerifyNonMembership(types.GetSDKSpecs(), &root, path)
 
 			if tc.shouldPass {
-				// nolint: scopelint
+				//nolint: scopelint
 				suite.Require().NoError(err, "test case %d should have passed", i)
 			} else {
-				// nolint: scopelint
+				//nolint: scopelint
 				suite.Require().Error(err, "test case %d should have failed", i)
 			}
 		})