-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make isAllowedAddress private #2985
Make isAllowedAddress private #2985
Conversation
func isAllowedAddress(ctx sdk.Context, receiver string, allowedAddrs []string) bool { | ||
for _, addr := range allowedAddrs { | ||
ctx.GasMeter().ConsumeGas(gasCostPerIteration, "transfer authorization") | ||
if addr == receiver { | ||
return true | ||
} | ||
} | ||
return false | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved this to the bottom of the file as it was in between multiple public methods.
var ( | ||
_ authz.Authorization = &TransferAuthorization{} | ||
) | ||
var _ authz.Authorization = &TransferAuthorization{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is required to make formatting pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
Make isAllowedAddress private. This PR also fixes compilation issues in the unit tests.
part of: #2960
Commit Message / Changelog Entry
N/A
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.