Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ics10: add requirements doc #3140

Merged
merged 8 commits into from
Feb 20, 2024

Conversation

blasrodri
Copy link
Contributor

Description

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@womensrights womensrights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving a few comments on the draft here, the features, and below would of course need to be written and I can give some more feedback then

docs/requirements/ics10-requirements.md Show resolved Hide resolved
docs/requirements/ics10-requirements.md Outdated Show resolved Hide resolved
docs/requirements/ics10-requirements.md Outdated Show resolved Hide resolved
docs/requirements/ics10-requirements.md Outdated Show resolved Hide resolved
docs/requirements/ics10-requirements.md Outdated Show resolved Hide resolved
docs/requirements/ics10-requirements.md Show resolved Hide resolved
docs/requirements/ics10-requirements.md Show resolved Hide resolved
@crodriguezvega crodriguezvega self-assigned this Nov 24, 2023
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to merge and fix the markdown issues immediately after.

@crodriguezvega crodriguezvega merged commit 7119eea into cosmos:main Feb 20, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants