imp: make event emission functions unexported #3205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
AdityaSripal,
charleenfei,
colin-axner and
damiannolan
as code owners
|
I think I could also make |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3205 +/- ##
=======================================
Coverage 78.60% 78.60%
=======================================
Files 177 177
Lines 12420 12420
=======================================
Hits 9763 9763
Misses 2231 2231
Partials 426 426
|
colin-axner
reviewed
Feb 27, 2023
| // EmitCreateClientEvent emits a create client event | ||
| func EmitCreateClientEvent(ctx sdk.Context, clientID string, clientState exported.ClientState) { | ||
| // EmitUpgradeChainEvent emits an upgrade chain event. | ||
| func EmitUpgradeChainEvent(ctx sdk.Context, height int64) { |
There was a problem hiding this comment.
Is there a reason this is still public?
There was a problem hiding this comment.
This one I couldn't change because is used here. But maybe there's also a way around, if we can move the event emission inside SetUpgradedConsensusState?
There was a problem hiding this comment.
I think it might be a good idea to move all our begin blocker actions to the keeper directory (within abci.go).
func (k Keeper) BeginBlocker(ctx sdk.Context) {
// functionality
}// within ibc module.go
func (am AppModule) BeginBlock(ctx sdk.Context, req abci.RequestBeginBlock) {
am.keeper.ClientKeeper.BeginBlocker(ctx)
}
colin-axner
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Most of the event emission functions can be unexported.
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.