Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modify simapp to fulfill the sdk runtime.AppI interface #3216

Merged

Conversation

phamminh0811
Copy link
Contributor

@phamminh0811 phamminh0811 commented Feb 28, 2023

Description

closes: #3152
Modify simapp to fulfill the sdk runtime.AppI interface

Commit Message / Changelog Entry

chore: modify simapp to fulfill the sdk runtime.AppI interface

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phamminh0811 :) The changes look good to me

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@codecov-commenter
Copy link

Codecov Report

Merging #3216 (f808a46) into main (62e09ed) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3216   +/-   ##
=======================================
  Coverage   78.54%   78.54%           
=======================================
  Files         181      181           
  Lines       12580    12580           
=======================================
  Hits         9881     9881           
  Misses       2262     2262           
  Partials      437      437           
Impacted Files Coverage Δ
modules/core/02-client/migrations/v7/store.go 68.85% <100.00%> (ø)
modules/core/02-client/simulation/decoder.go 100.00% <100.00%> (ø)
...dules/light-clients/06-solomachine/client_state.go 88.28% <100.00%> (ø)

@crodriguezvega crodriguezvega merged commit 422b951 into cosmos:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify simapp to fulfill the sdk runtime.AppI interface
5 participants