Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run e2e on R4R #3330

Merged
merged 9 commits into from
Mar 23, 2023
Merged

Only run e2e on R4R #3330

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
45c9359
only run e2e on R4R
chatton Mar 23, 2023
f24c97b
use ready_for_review type
chatton Mar 23, 2023
6021045
use pull request target
chatton Mar 23, 2023
6887da9
fix yaml syntax
chatton Mar 23, 2023
e477340
trigger e2e
chatton Mar 23, 2023
70316e7
wip
chatton Mar 23, 2023
6b94095
use synchronize and ready_for_review types
chatton Mar 23, 2023
021835c
commit after marked for draft
chatton Mar 23, 2023
90d9c47
skip all e2e jobs when the PR is in draft
chatton Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .github/workflows/e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ name: Tests / E2E
on:
workflow_dispatch:
pull_request:
types:
# trigger workflow if changes are pushed to the branch.
- synchronize
# trigger workflow if PR is marked ready for review.
- ready_for_review
paths-ignore:
- "docs/**"
- "**.md"
Expand All @@ -16,7 +21,7 @@ on:

jobs:
determine-image-tag:
if: ${{ !github.event.pull_request.head.repo.fork && github.actor != 'dependabot[bot]' }}
if: ${{ !github.event.pull_request.draft && !github.event.pull_request.head.repo.fork && github.actor != 'dependabot[bot]' }}
runs-on: ubuntu-latest
outputs:
simd-tag: ${{ steps.get-tag.outputs.simd-tag }}
Expand All @@ -37,7 +42,7 @@ jobs:
fi

build-e2e:
if: ${{ !github.event.pull_request.head.repo.fork && github.actor != 'dependabot[bot]' }}
if: ${{ !github.event.pull_request.draft && !github.event.pull_request.head.repo.fork && github.actor != 'dependabot[bot]' }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand All @@ -54,7 +59,9 @@ jobs:
done

e2e:
if: ${{ !github.event.pull_request.head.repo.fork && github.actor != 'dependabot[bot]' }}
# we will be running this job if the PR has not yet been marked for review, and we push additional changes.
# we skip the job in this case.
if: ${{ !github.event.pull_request.draft && !github.event.pull_request.head.repo.fork && github.actor != 'dependabot[bot]' }}
colin-axner marked this conversation as resolved.
Show resolved Hide resolved
needs:
- determine-image-tag
- build-e2e # don't attempt any tests unless the e2e code compiles successfully.
Expand Down