chore(api)!: add missing/remove unnecessary gogoproto directive #3856
Conversation
crodriguezvega
requested review from
colin-axner,
AdityaSripal,
charleenfei,
damiannolan,
chatton,
DimitrisJim and
srdtrk
as code owners
| controllerPortID, msgChanOpenInitRes.GetChannelId(), | ||
| msgChanOpenTryRes.GetChannelId(), msgChanOpenTryRes.GetVersion(), | ||
| controllerPortID, msgChanOpenInitRes.ChannelId, | ||
| msgChanOpenTryRes.ChannelId, msgChanOpenTryResVersion, |
There was a problem hiding this comment.
to save you the trouble of looking, msgChanOpenTry.Version, similarly in lines 244 and 374.
There was a problem hiding this comment.
oh, man, thank you so much. I was scratching my head what the error was. 😓
There was a problem hiding this comment.
yeah, the script that builds the e2e's discards stdout/stderr which was silly of me to add. Amending them now so errors like these won't be cryptic from now on 😆
| @@ -35,6 +35,9 @@ message MsgRegisterInterchainAccount { | |||
|
|
|||
| // MsgRegisterInterchainAccountResponse defines the response for Msg/RegisterAccount | |||
| message MsgRegisterInterchainAccountResponse { | |||
| option (gogoproto.equal) = false; | |||
There was a problem hiding this comment.
Are the equal directives needed? See discussion
There was a problem hiding this comment.
Is it ok if a remove them all in a separate PR addressing #3871?
There was a problem hiding this comment.
unfortunate that we added them in the update messages since that will need to be fixed in a separate PR to 04-channel. I'd vote for removing them here if we decide to go with #3871 but not strongly opinionated on it.
There was a problem hiding this comment.
It's just much easier for me to merge this as is and then delete all the occurrences in a separate PR, instead of now looking one by one at the places where I added them and delete them. 😓
There was a problem hiding this comment.
yea, can totally see that. Its the little OCD voices that are complaining with the fact that something is added only to be removed. I have zero issues going with the route thats easier for you.
There was a problem hiding this comment.
i can also help rm the occurences in this pr! i agree that it's probably better to remove them in this pr rather than opening a separate one
There was a problem hiding this comment.
Thank you, @charleenfei!
crodriguezvega
changed the title
# Conflicts: # modules/core/02-client/types/tx.pb.go
Description
Adds
where it was missing. See https://github.com/cosmos/ibc-go/pull/3845/files#r1229579617
Removes
Since it is not needed. See #3858 (comment)
closes: #3871
Commit Message / Changelog Entry
chore(api)!: add missing/remove unnecessary gogoproto directivesee the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.