Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding
OnChanUpgradeInit
handler implementation to29-fee
#4019feat: adding
OnChanUpgradeInit
handler implementation to29-fee
#4019Changes from 10 commits
3765d93
79cb7f8
64563e8
e951cc1
9907ea9
391d44b
66ad804
09fbbac
b19b53b
1f53cd6
db256b2
ae1ea37
fb6a42a
a349f4e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we indicate that the version could not be unmarshaled into the metadata?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally was thinking that this would be wrapped by the caller like for example:
errorsmod.Wrapf(err, "failed to unmarshal ICS29 counterparty version metadata: %s)
But I like this suggestion! Changed it to return this here:
errorsmod.Wrapf(ErrInvalidVersion, "failed to unmarshal metadata from version: %s", version)
. From caller we can justWrap(err, "invalid counterparty version")