Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: delegate store operation of clientState and consensusState in initialize to contract #4033

Conversation

crodriguezvega
Copy link
Contributor

Description

This implements for now only the ibc-go part. Tests are expected to fail; we need new versions of contracts that handle setting the client state and consensus state.

closes: #3956

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

…ation-of-clientstate-and-consensusstate-in-initialize-to-contract
@vmarkushin
Copy link
Contributor

vmarkushin commented Jul 21, 2023

I've updated the contract according to the changes, but these two tests are failing because of an incorrect data, please check.

Can I push the new contracts to the repo so the CI can pass?

@crodriguezvega
Copy link
Contributor Author

I've updated the contract according to the changes, but these two tests are failing because of an incorrect data, please check.

Can I push the new contracts to the repo so the CI can pass?

Thank you, @vmarkushin. I just gave you write permissions, so feel free to push to any of the 08-wasm branches. When you upload the contracts, I will check those tests.

@vmarkushin
Copy link
Contributor

Thank you, @vmarkushin. I just gave you write permissions, so feel free to push to any of the 08-wasm branches. When you upload the contracts, I will check those tests.

Deal, thanks!

vmarkushin and others added 2 commits July 21, 2023 17:49
…tion-of-clientstate-and-consensusstate-in-initialize-to-contract' into carlos/3956-delegate-store-operation-of-clientstate-and-consensusstate-in-initialize-to-contract
@crodriguezvega crodriguezvega marked this pull request as ready for review August 1, 2023 07:57
…ation-of-clientstate-and-consensusstate-in-initialize-to-contract
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor nit, would be nice to open separate issue about moving all these in a common file & documenting them.

…ation-of-clientstate-and-consensusstate-in-initialize-to-contract
@crodriguezvega crodriguezvega merged commit de89920 into feat/wasm-clients Aug 1, 2023
6 of 14 checks passed
@crodriguezvega crodriguezvega deleted the carlos/3956-delegate-store-operation-of-clientstate-and-consensusstate-in-initialize-to-contract branch August 1, 2023 11:27
@faddat faddat mentioned this pull request Sep 10, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants