-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp: delegate store operation of clientState
and consensusState
in initialize
to contract
#4033
Conversation
…ation-of-clientstate-and-consensusstate-in-initialize-to-contract
…ation-of-clientstate-and-consensusstate-in-initialize-to-contract
Thank you, @vmarkushin. I just gave you write permissions, so feel free to push to any of the |
Deal, thanks! |
…tion-of-clientstate-and-consensusstate-in-initialize-to-contract' into carlos/3956-delegate-store-operation-of-clientstate-and-consensusstate-in-initialize-to-contract
…ation-of-clientstate-and-consensusstate-in-initialize-to-contract
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor nit, would be nice to open separate issue about moving all these in a common file & documenting them.
…ation-of-clientstate-and-consensusstate-in-initialize-to-contract
Description
This implements for now only the ibc-go part. Tests are expected to fail; we need new versions of contracts that handle setting the client state and consensus state.
closes: #3956
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.