-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] deps: upgrade capability to sdk v0.50 #4057
Conversation
@@ -26,7 +26,6 @@ import ( | |||
) | |||
|
|||
var ( | |||
_ module.BeginBlockAppModule = (*AppModule)(nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tac0turtle I see there's now a HasABCIEndblock interface, is there a similar interface for BeginBlock
now or is it inferred somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is for legacy? and now core/appmodule is the std with HasBeginBlocker moving forward?
Can't make an interface assertion here yet as arg in the new interface is a regular go ctx
ohhhh this is a WONDEFUL change. Love how there's no more dependency! |
I think this PR can be closed and superseded by #4068. After some thought and a few hours of working on this I felt there was more value in refactoring the capability tests to not depend on any simapp at all. Some of the tests in |
Description
This PR removes the dependency of ibc-go simapp from the capability module and upgrades it to sdk v0.50
closes: #4055
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.