Code

feat: ica app version negotiation#410

Code

Merged

damiannolan merged 18 commits intointerchain-accountscosmos/ibc-go:interchain-accountsfrom damian/378-ica-set-addr-on-ctrlcosmos/ibc-go:damian/378-ica-set-addr-on-ctrlCopy head branch name to clipboardSep 20, 2021

+364-99

Commits

Commits on Sep 15, 2021

• adding NegotiateAppVersion implementation and tests

  damiannolan

  committed
  18990b4

  Copy full SHA for 18990b4

• updating GenerateAddress to return sdk.AccAddress, fixing tests

  damiannolan

  committed
  49e2901

  Copy full SHA for 49e2901

• updating ica handshake flow to parse address from version string, fixing associated tests

  damiannolan

  committed
  1f73b16

  Copy full SHA for 1f73b16

• updating module_tests

  damiannolan

  committed
  b967f08

  Copy full SHA for b967f08

• derive ica addresses from module account addr

  damiannolan

  committed
  52fe314

  Copy full SHA for 52fe314

• removing unused keys

  damiannolan

  committed
  bd66f33

  Copy full SHA for bd66f33

Commits on Sep 16, 2021

• adding improved version validation, updating tests

  damiannolan

  committed
  62e5c39

  Copy full SHA for 62e5c39

• removing redundant local var - owner

  damiannolan

  committed
  4ee74bf

  Copy full SHA for 4ee74bf

• updating Delimiter godoc

  damiannolan

  committed
  b2f3e3b

  Copy full SHA for b2f3e3b

• updating validation logic

  damiannolan

  committed
  c7d7804

  Copy full SHA for c7d7804

• adding test cases for ValidateVersion

  damiannolan

  committed
  001313c

  Copy full SHA for 001313c

Commits on Sep 17, 2021

• adding additional validation testcase, updating godocs

  damiannolan

  committed
  d6725e1

  Copy full SHA for d6725e1

• updating Version -> VersionPrefix, error msgs, validation tests

  damiannolan

  committed
  32240ff

  Copy full SHA for 32240ff

• updating NewAppVersion func sig and usage

  damiannolan

  committed
  e4af997

  Copy full SHA for e4af997

Commits on Sep 20, 2021

• updating NewAppVersion args and returning more appropriate errors for handshake

  damiannolan

  committed
  18e9601

  Copy full SHA for 18e9601

• Merge branch 'interchain-accounts' into damian/378-ica-set-addr-on-ctrl

  damiannolan

  authored
  c691632

  Copy full SHA for c691632

• Update modules/apps/27-interchain-accounts/keeper/handshake.go

  Show description for 3d5baab
  

  damiannolan

  and

  seantking

  authored
  3d5baab

  Copy full SHA for 3d5baab

• updating ValidateVersion godoc

  damiannolan

  committed
  f400bdc

  Copy full SHA for f400bdc