-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Version interface and casting functions from 03-connection #4110
Remove Version interface and casting functions from 03-connection #4110
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4110 +/- ##
==========================================
+ Coverage 79.45% 79.47% +0.01%
==========================================
Files 188 188
Lines 12990 12973 -17
==========================================
- Hits 10321 10310 -11
+ Misses 2240 2234 -6
Partials 429 429
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me; thank you, @Reecepbcups!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes me so happy! Thank you @Reecepbcups, great cleanup
Description
ExportedVersionsToProto
&ProtoVersionsToExported
casting functions (and removed from single .md file)TODO Change log entryNo need we will use the commit message to generate the changelog.closes: #1690
Commit Message / Changelog Entry
imp: remove `Version` interface and casting functions from 03-connection
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.