Add test for parsing connection paths #4111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reecepbcups
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
Reecepbcups
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4111 +/- ##
==========================================
+ Coverage 79.56% 79.66% +0.09%
==========================================
Files 188 188
Lines 13201 13201
==========================================
+ Hits 10504 10517 +13
+ Misses 2266 2253 -13
Partials 431 431 |
charleenfei
approved these changes
Jul 19, 2023
modules/core/24-host/parse.go
Outdated
| "strconv" | ||
| "strings" | ||
|
|
||
| errorsmod "cosmossdk.io/errors" | ||
| ) | ||
|
|
||
| var pathRegex = regexp.MustCompile("[^/]+") |
There was a problem hiding this comment.
maybe a small godoc here explaining what the regex is doing?
|
@Reecepbcups We discussed internally this PR and we'd rather keep using |
crodriguezvega
changed the title
|
@crodriguezvega makes sense, completed |
damiannolan
approved these changes
Sep 12, 2023
crodriguezvega
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add test for parsing of connection path.
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.