Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Parent Proposal for CCV and use created client to verify Handshake #439

Closed
wants to merge 8 commits into from

Conversation

AdityaSripal
Copy link
Member

@AdityaSripal AdityaSripal commented Sep 24, 2021

Description

closes: #392

  • Creates a proposal type and handling functions for creating a new child chain
  • Upon passing the proposal, the IBC client for the child chain is created automatically
  • The CCV channel on the parent chain for that child chain MUST be built on top of the above client.
  • This ensures that the channel is speaking to the correct child chain and not an imposter

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@AdityaSripal AdityaSripal changed the base branch from main to cross-chain-validation September 24, 2021 11:27
@AdityaSripal AdityaSripal marked this pull request as draft September 24, 2021 11:50
@AdityaSripal
Copy link
Member Author

Closed in favor of cosmos/interchain-security#5

@colin-axner colin-axner deleted the aditya/parent-proposal branch October 7, 2021 10:23
faddat pushed a commit to notional-labs/ibc-go that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant