Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mod/capability): implment appmodule.HasBeginBlocker interface #4557

Merged
merged 5 commits into from
Sep 5, 2023
Merged

fix(mod/capability): implment appmodule.HasBeginBlocker interface #4557

merged 5 commits into from
Sep 5, 2023

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented Sep 4, 2023 •
edited
Loading

Description

Without this BeginBlock would never be called and mem store capabilities would not be reinitialised.

ref #4559

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@damiannolan damiannolan marked this pull request as ready for review September 4, 2023 16:50
@damiannolan damiannolan changed the title fix: implment appmodule.HasBeginBlocker interface fix(mod/capability): implment appmodule.HasBeginBlocker interface Sep 4, 2023
DimitrisJim
DimitrisJim approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

charleenfei
charleenfei approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@charleenfei charleenfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this quick fix @damiannolan! yet another nice catch from @colin-axner 🥇

chatton
chatton approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damiannolan damiannolan merged commit 432db29 into main Sep 5, 2023
59 checks passed
@damiannolan damiannolan deleted the damian/fix-begin-blocker-interface branch September 5, 2023 09:53
mergify bot pushed a commit that referenced this pull request Sep 5, 2023
@damiannolan @mergify
fix(mod/capability): implment appmodule.HasBeginBlocker interface (#4557
120cc5a 
)

(cherry picked from commit 432db29)
@mergify mergify bot mentioned this pull request Sep 5, 2023
Merged
damiannolan added a commit that referenced this pull request Sep 5, 2023
@mergify @damiannolan
fix(mod/capability): implment appmodule.HasBeginBlocker interface (#4557
b82ba55 
) (#4572)

(cherry picked from commit 432db29)

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
@damiannolan damiannolan added the capability Issues for capability modules label Sep 12, 2023
@damiannolan damiannolan mentioned this pull request Sep 12, 2023
Merged
9 tasks
@colin-axner colin-axner mentioned this pull request Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleenfei charleenfei charleenfei approved these changes

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@chatton chatton chatton approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

Assignees
No one assigned
Labels
capability Issues for capability modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damiannolan @chatton @DimitrisJim @charleenfei