Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix dead links #4678

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Sep 16, 2023

Description

Intro is now 00-intro.md

Commit Message / Changelog Entry

docs: fix link to building modules docs

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the 2nd time the SDK broke the links in the last week I think. Maybe we should turn these into permanent links? That would need to be discussed in its own issue.

@srdtrk srdtrk merged commit b93d02a into cosmos:main Sep 16, 2023
15 checks passed
mergify bot pushed a commit that referenced this pull request Sep 18, 2023
damiannolan pushed a commit that referenced this pull request Sep 18, 2023
(cherry picked from commit b93d02a)

Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants