Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace all instances of collections.Contains with slices.Contains across the entire codebase #4685

Merged
merged 5 commits into from
Sep 18, 2023

Conversation

CyberGA
Copy link
Contributor

@CyberGA CyberGA commented Sep 17, 2023

Description

closes: #4669

This PR replaces all instances of collections.Contains with slices.Contains across the entire codebase

Commit Message / Changelog Entry

improvements: replace all instances of collections.Contains with slices.Contains

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @CyberGA

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope, thanks 🚀

@codecov-commenter
Copy link

Codecov Report

Merging #4685 (ec8b826) into main (4fcb399) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4685      +/-   ##
==========================================
- Coverage   79.66%   79.65%   -0.01%     
==========================================
  Files         188      187       -1     
  Lines       13201    13195       -6     
==========================================
- Hits        10517    10511       -6     
  Misses       2253     2253              
  Partials      431      431              
Files Changed Coverage Δ
.../apps/27-interchain-accounts/host/client/cli/tx.go 27.27% <0.00%> (ø)
...ules/apps/27-interchain-accounts/types/metadata.go 78.49% <100.00%> (ø)
modules/core/02-client/types/params.go 100.00% <100.00%> (ø)
modules/core/03-connection/types/version.go 96.20% <100.00%> (ø)

@damiannolan damiannolan merged commit 234ff4e into cosmos:main Sep 18, 2023
56 of 57 checks passed
@chatton
Copy link
Contributor

chatton commented Sep 18, 2023

thanks @CyberGA !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace all collections.Contains instances with slices.Contains
6 participants