Improve mock wasmvm query implementation #4879
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #4873
The implementation wasn't as straightforward as I was expecting.
It seems it is not possible to use type constraints as keys to a map, because of this I opted to use the type name and pre-populate the map with all allowed types so it is only possible to register types for the expected values.
I needed to move the mock vm to the same package as the types to be able to actually do this.
I'm not too happy about that, and I think we can actually revert that if we just opt to use a set of string constants instead of types. Open to suggestions!
I also looked into the possibility of using an
internal
directory, but types aren't importable from types_test from a separate package.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.