Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(08-wasm): renamed 'grandpaClientID' -> 'defaultWasmClientID' #4912

Merged

Conversation

srdtrk
Copy link
Member

@srdtrk srdtrk commented Oct 19, 2023

Description

closes: #XXXX

Commit Message / Changelog Entry

style(08-wasm): renamed 'grandpaClientID' -> 'defaultWasmClientID'

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grepping for this I find a couple more in misbehaviour_handle_test.go, commented out tho and likely to be replaced, still good to switch em up just in case tho

@srdtrk srdtrk merged commit 335286d into feat/wasm-clients Oct 19, 2023
61 checks passed
@srdtrk srdtrk deleted the serdar/wasm-test-style-grandpaClientID-rename branch October 19, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants