Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(08-wasm): added 'TestUpdateState' using mockVM #4914

Merged
merged 19 commits into from
Oct 25, 2023

Conversation

srdtrk
Copy link
Member

@srdtrk srdtrk commented Oct 19, 2023

Description

closes: #4831

Commit Message / Changelog Entry

test(08-wasm): added 'TestUpdateState' using mockVM

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@srdtrk srdtrk added testing Testing package and unit/integration tests 08-wasm labels Oct 19, 2023
Copy link
Contributor

@charleenfei charleenfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small comments, nice code coverage!

@srdtrk srdtrk linked an issue Oct 21, 2023 that may be closed by this pull request
3 tasks
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @srdtrk! I agree also with the comments that @charleenfei left.

modules/light-clients/08-wasm/types/update_test.go Outdated Show resolved Hide resolved
modules/light-clients/08-wasm/types/update_test.go Outdated Show resolved Hide resolved
modules/light-clients/08-wasm/types/update_test.go Outdated Show resolved Hide resolved
@srdtrk srdtrk merged commit dd6d028 into feat/wasm-clients Oct 25, 2023
61 checks passed
@srdtrk srdtrk deleted the serdar/issue#4831-wasm-TestUpdateState branch October 25, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08-wasm testing Testing package and unit/integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TestUpdateState using mock vm for 08-wasm
4 participants