Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional coverage for test initialize. #4940

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

DimitrisJim
Copy link
Contributor

Description

some unchecked cases for this test

closes: #XXXX

Commit Message / Changelog Entry

chore: increase cov for TestInitialize

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I didn't really have a good idea of what I was supposed to test when I wrote this as it was the first one.

@srdtrk srdtrk added the testing Testing package and unit/integration tests label Oct 25, 2023
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice attention to detail!

@DimitrisJim DimitrisJim merged commit e2522b2 into feat/wasm-clients Oct 25, 2023
61 checks passed
@DimitrisJim DimitrisJim deleted the jim/initialize-coverage branch October 25, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08-wasm testing Testing package and unit/integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants