Add mock test for CheckSubstituteAndUpdateState. #4950
Conversation
DimitrisJim
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
DimitrisJim
force-pushed
the
jim/4829-test-check-substitute-and-update-state
branch
6 times, most recently
from
6862662
to
3c5f5b0
Compare
DimitrisJim
force-pushed
the
jim/4829-test-check-substitute-and-update-state
branch
from
3c5f5b0
to
0cb3adb
Compare
| expErr error | ||
| }{ | ||
| { | ||
| "success", |
There was a problem hiding this comment.
adding a check for writes/asserting reads from the store passed in will be done in PR for the wrappedStore.
|
talked with @charleenfei, will mark as draft until #4862 is merged to include additional tests for changes added there |
DimitrisJim
force-pushed
the
jim/4829-test-check-substitute-and-update-state
branch
from
54c6419
to
e1e9eb0
Compare
| @@ -21,7 +21,7 @@ var ( | |||
| queryTypes = [...]any{types.StatusMsg{}, types.ExportMetadataMsg{}, types.TimestampAtHeightMsg{}, types.VerifyClientMessageMsg{}, types.CheckForMisbehaviourMsg{}} | |||
|
|
|||
| // sudoTypes contains all the possible sudo message types. | |||
| sudoTypes = [...]any{types.UpdateStateMsg{}, types.UpdateStateOnMisbehaviourMsg{}, types.VerifyUpgradeAndUpdateStateMsg{}, types.VerifyMembershipMsg{}, types.VerifyNonMembershipMsg{}} | |||
| sudoTypes = [...]any{types.UpdateStateMsg{}, types.UpdateStateOnMisbehaviourMsg{}, types.VerifyUpgradeAndUpdateStateMsg{}, types.VerifyMembershipMsg{}, types.VerifyNonMembershipMsg{}, types.MigrateClientStoreMsg{}} | |||
There was a problem hiding this comment.
adding these as necessary
| "failure: code hashes do not match", | ||
| func() { | ||
| substituteClientState = &types.ClientState{ | ||
| CodeHash: []byte("invalid"), |
There was a problem hiding this comment.
I thought about using a mock value here but can't see many occasions where we do this
There was a problem hiding this comment.
i think we have many mock code hash instances like in genesis_test,wasm_test, but maybe just better to have a separate pr cleaning all these up as we've been doing.
There was a problem hiding this comment.
yea, can also move all vals to a values.go file as we do for top level testing/.
|
|
| func() { | ||
| substituteClientState = &ibctm.ClientState{} | ||
| }, | ||
| clienttypes.ErrInvalidClient, |
There was a problem hiding this comment.
could maybe wrap the error with the error string in the code to make it more specific, but fine as is
There was a problem hiding this comment.
could do, this is pretty prevalent currently. Could be nice to open overarching issue and maybe pick it up in future?
There was a problem hiding this comment.
I'm happy with whatever :)
|
We can remove the grandpa test as well? That will be handled by e2e's |
DimitrisJim
deleted the
jim/4829-test-check-substitute-and-update-state
branch
Description
closes: #4829
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.