imp: CheckSubstituteAndUpdateState for 08-wasm client
#4974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleenfei
commented
Oct 27, 2023
| @@ -78,203 +78,6 @@ func (suite *TypesTestSuite) TestCheckSubstituteAndUpdateStateGrandpa() { | |||
| } | |||
| } | |||
|
|
|||
| // func (suite *TypesTestSuite) TestCheckSubstituteAndUpdateStateBasicTendermint() { | |||
There was a problem hiding this comment.
this test is covered in this pr
charleenfei
commented
Oct 27, 2023
| payload := SudoMsg{ | ||
| CheckSubstituteAndUpdateState: &CheckSubstituteAndUpdateStateMsg{}, | ||
| MigrateClientStore: &MigrateClientStoreMsg{}, |
There was a problem hiding this comment.
see this pr for the contract changes pertaining to this new msg type
charleenfei
force-pushed
the
charly/issue#4862-changes-to-checksubstituteandupdatestate-function-of-clientstate
branch
from
2ec1e00
to
5b984cf
Compare
charleenfei
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
colin-axner
approved these changes
Oct 30, 2023
…cksubstituteandupdatestate-function-of-clientstate
DimitrisJim
approved these changes
Oct 30, 2023
|
Looks like the mock vm needs to be updated with the type changes in order to build |
charleenfei
deleted the
charly/issue#4862-changes-to-checksubstituteandupdatestate-function-of-clientstate
branch
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #4862
NOTE the grandpa test will fail on this PR until contract changes are merged for the new msg type.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.