feat(08-wasm): implement 'RemoveCodeHash' RPC endpoint #5006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srdtrk
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
3 tasks
DimitrisJim
reviewed
Nov 7, 2023
Comment on lines
+372
to
+373
| // Verify events | ||
| suite.Require().Len(events, 0) |
There was a problem hiding this comment.
I wouldn't add this necessarily but if we do we can atleast move getting the events in the successful case.
There was a problem hiding this comment.
You think we should emit events?
There was a problem hiding this comment.
is there actually 0 events emitted? hmm, would've thought sdk baseapp would emit some std ones
There was a problem hiding this comment.
The context is not going through the baseapp. I'm directly calling the msg_server handler with the context
There was a problem hiding this comment.
not sure re events. I dont think they'd hurt tho.
chatton
reviewed
Nov 7, 2023
damiannolan
reviewed
Nov 8, 2023
DimitrisJim
reviewed
Nov 8, 2023
damiannolan
approved these changes
Nov 8, 2023
DimitrisJim
approved these changes
Nov 8, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #4951
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.