imp: use wasm VM CreateChecksum #5123

crodriguezvega · 2023-11-16T09:36:21Z

Description

closes: #5071

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md).
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards and Go style guide.
Wrote unit and integration tests.
Updated relevant documentation (docs/) or specification (x/<module>/spec/).
Added relevant godoc comments.
Provide a commit message to be used for the changelog entry in the PR description for review.
Re-reviewed Files changed in the Github PR explorer.
Review Codecov Report in the comment section below once CI passes.

modules/light-clients/08-wasm/types/wasm.go

modules/light-clients/08-wasm/keeper/msg_server_test.go

…-of-duplicating-it

DimitrisJim · 2023-11-17T11:30:48Z

modules/light-clients/08-wasm/keeper/export_test.go

@@ -1,9 +0,0 @@
-package keeper


DimitrisJim · 2023-11-17T11:32:44Z

modules/light-clients/08-wasm/types/wasm.go

 	"github.com/cosmos/ibc-go/modules/light-clients/08-wasm/internal/ibcwasm"
 )

 // Checksum is a type alias used for wasm byte code checksums.
-type Checksum []byte
+type Checksum = wasmvmtypes.Checksum


not strictly necessary to do this alias and wrapping, helps with keeping these local to this file, removing imports and allowing for localized changes if they are required in future. Could drop if people don't like it

…-of-duplicating-it

damiannolan

Beautiful! Nice cleanup @crodriguezvega ❤️

modules/light-clients/08-wasm/keeper/keeper.go

modules/light-clients/08-wasm/types/wasm.go

Co-authored-by: Damian Nolan <damiannolan@gmail.com>

…-of-duplicating-it

DimitrisJim

looks gorgeous to me!

crodriguezvega · 2023-11-20T19:06:57Z

Thank you for your contributions on this one, @DimitrisJim!

* use wasm VM CreateChecksum * review comments * lint * lint 2 * Remove raw calls to sha256, clean up handling of Checksums. * Update modules/light-clients/08-wasm/keeper/keeper.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> * Document this bad boy. --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit a231fea) # Conflicts: # modules/light-clients/08-wasm/keeper/events.go # modules/light-clients/08-wasm/keeper/genesis.go # modules/light-clients/08-wasm/keeper/keeper.go # modules/light-clients/08-wasm/keeper/msg_server_test.go # modules/light-clients/08-wasm/keeper/snapshotter.go # modules/light-clients/08-wasm/keeper/snapshotter_test.go # modules/light-clients/08-wasm/testing/mock_engine.go # modules/light-clients/08-wasm/testing/values.go # modules/light-clients/08-wasm/testing/wasm_endpoint.go # modules/light-clients/08-wasm/types/client_state_test.go # modules/light-clients/08-wasm/types/migrate_contract_test.go # modules/light-clients/08-wasm/types/msgs_test.go # modules/light-clients/08-wasm/types/types_test.go # modules/light-clients/08-wasm/types/validation.go # modules/light-clients/08-wasm/types/validation_test.go # modules/light-clients/08-wasm/types/vm.go # modules/light-clients/08-wasm/types/wasm.go # modules/light-clients/08-wasm/types/wasm_test.go

* imp: use wasm VM CreateChecksum (#5123) * use wasm VM CreateChecksum * review comments * lint * lint 2 * Remove raw calls to sha256, clean up handling of Checksums. * Update modules/light-clients/08-wasm/keeper/keeper.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> * Document this bad boy. --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit a231fea) # Conflicts: # modules/light-clients/08-wasm/keeper/events.go # modules/light-clients/08-wasm/keeper/genesis.go # modules/light-clients/08-wasm/keeper/keeper.go # modules/light-clients/08-wasm/keeper/msg_server_test.go # modules/light-clients/08-wasm/keeper/snapshotter.go # modules/light-clients/08-wasm/keeper/snapshotter_test.go # modules/light-clients/08-wasm/testing/mock_engine.go # modules/light-clients/08-wasm/testing/values.go # modules/light-clients/08-wasm/testing/wasm_endpoint.go # modules/light-clients/08-wasm/types/client_state_test.go # modules/light-clients/08-wasm/types/migrate_contract_test.go # modules/light-clients/08-wasm/types/msgs_test.go # modules/light-clients/08-wasm/types/types_test.go # modules/light-clients/08-wasm/types/validation.go # modules/light-clients/08-wasm/types/validation_test.go # modules/light-clients/08-wasm/types/vm.go # modules/light-clients/08-wasm/types/wasm.go # modules/light-clients/08-wasm/types/wasm_test.go * lint: simplify newHash[:] -> newHash to satifsy linting overlords --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: Damian Nolan <damiannolan@gmail.com>

* use wasm VM CreateChecksum * review comments * lint * lint 2 * Remove raw calls to sha256, clean up handling of Checksums. * Update modules/light-clients/08-wasm/keeper/keeper.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> * Document this bad boy. --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit a231fea)

* use wasm VM CreateChecksum * review comments * lint * lint 2 * Remove raw calls to sha256, clean up handling of Checksums. * Update modules/light-clients/08-wasm/keeper/keeper.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> * Document this bad boy. --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit a231fea) Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

use wasm VM CreateChecksum

4c46e60

crodriguezvega added backport-wasm-v0.1.x+ibc-go-v7.3.x-wasmvm-v1.4.x labels Nov 16, 2023

crodriguezvega linked an issue Nov 16, 2023 that may be closed by this pull request

Use wasmvm.CreateChecksum instead of duplicating it. #5071

Closed

3 tasks

github-actions bot added the 08-wasm label Nov 16, 2023

crodriguezvega commented Nov 16, 2023

View reviewed changes

modules/light-clients/08-wasm/types/wasm.go Show resolved Hide resolved

modules/light-clients/08-wasm/keeper/msg_server_test.go Outdated Show resolved Hide resolved

crodriguezvega added 4 commits November 16, 2023 21:33

review comments

ec97735

lint

2582138

lint 2

05b6f90

Merge branch 'main' into carlos/5071-use-wasmvmcreatechecksum-instead…

41dc4a3

…-of-duplicating-it

crodriguezvega marked this pull request as ready for review November 16, 2023 20:43

crodriguezvega requested review from colin-axner, AdityaSripal, damiannolan, charleenfei and srdtrk as code owners November 16, 2023 20:43

crodriguezvega and others added 2 commits November 17, 2023 10:35

Merge branch 'main' into carlos/5071-use-wasmvmcreatechecksum-instead…

cf18aa0

…-of-duplicating-it

Remove raw calls to sha256, clean up handling of Checksums.

fe6116d

DimitrisJim reviewed Nov 17, 2023

View reviewed changes

Merge branch 'main' into carlos/5071-use-wasmvmcreatechecksum-instead…

4a1ef05

…-of-duplicating-it

damiannolan approved these changes Nov 20, 2023

View reviewed changes

modules/light-clients/08-wasm/keeper/keeper.go Outdated Show resolved Hide resolved

modules/light-clients/08-wasm/types/wasm.go Show resolved Hide resolved

DimitrisJim and others added 3 commits November 20, 2023 15:41

Update modules/light-clients/08-wasm/keeper/keeper.go

1fb09ca

Co-authored-by: Damian Nolan <damiannolan@gmail.com>

Document this bad boy.

3ad4265

Merge branch 'main' into carlos/5071-use-wasmvmcreatechecksum-instead…

e9f26aa

…-of-duplicating-it

DimitrisJim approved these changes Nov 20, 2023

View reviewed changes

crodriguezvega merged commit a231fea into main Nov 20, 2023
73 checks passed

crodriguezvega deleted the carlos/5071-use-wasmvmcreatechecksum-instead-of-duplicating-it branch November 20, 2023 19:07

mergify bot mentioned this pull request Nov 20, 2023

imp: use wasm VM CreateChecksum (backport #5123) #5138

Merged

mergify bot mentioned this pull request Nov 20, 2023

imp: use wasm VM CreateChecksum (backport #5123) #5139

Closed

damiannolan added backport-wasm-v0.1.x+ibc-go-v7.3.x-wasmvm-v1.4.x and removed backport-wasm-v0.1.x+ibc-go-v7.3.x-wasmvm-v1.4.x labels Nov 29, 2023

crodriguezvega added backport-wasm-v0.1.x+ibc-go-v8.0.x-wasmvm-v1.5.x and removed backport-wasm-v0.1.x+ibc-go-v8.0.x-wasmvm-v1.5.x labels Nov 29, 2023

mergify bot mentioned this pull request Nov 29, 2023

imp: use wasm VM CreateChecksum (backport #5123) #5251

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

imp: use wasm VM CreateChecksum #5123

imp: use wasm VM CreateChecksum #5123

crodriguezvega commented Nov 16, 2023

DimitrisJim Nov 17, 2023

DimitrisJim Nov 17, 2023 •

edited

Loading

damiannolan left a comment

DimitrisJim left a comment

crodriguezvega commented Nov 20, 2023

imp: use wasm VM CreateChecksum #5123

imp: use wasm VM CreateChecksum #5123

Conversation

crodriguezvega commented Nov 16, 2023

Description

Commit Message / Changelog Entry

DimitrisJim Nov 17, 2023

Choose a reason for hiding this comment

DimitrisJim Nov 17, 2023 • edited Loading

Choose a reason for hiding this comment

damiannolan left a comment

Choose a reason for hiding this comment

DimitrisJim left a comment

Choose a reason for hiding this comment

crodriguezvega commented Nov 20, 2023

DimitrisJim Nov 17, 2023 •

edited

Loading