Validate before calculating checksum, move private functions at end, add context to mockvm errors. #5157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
damiannolan,
charleenfei,
chatton and
srdtrk
as code owners
crodriguezvega
approved these changes
Nov 22, 2023
chatton
approved these changes
Nov 22, 2023
| @@ -122,15 +122,15 @@ type MockWasmEngine struct { | |||
| // StoreCode implements the WasmEngine interface. | |||
| func (m *MockWasmEngine) StoreCode(code wasmvm.WasmCode) (wasmvm.Checksum, error) { | |||
| if m.StoreCodeFn == nil { | |||
| panic("mock engine is not properly initialized") | |||
| panic("mock engine is not properly initialized: StoreCodeFn is nil") | |||
There was a problem hiding this comment.
since we are modifying it already, a mega nit would be to change these to errors, I think we try and panic on errors in almost all places where we have panics.
…n vm.go, add context to mockvm errors.
DimitrisJim
force-pushed
the
jim/minor-wasm-nits
branch
from
8ae7ba3
to
413037d
Compare
DimitrisJim
added a commit
that referenced
this pull request
Nov 30, 2023
…add context to mockvm errors. (backport #5157) (#5265) * Validate before calculating checksum, move private functions at end, add context to mockvm errors. (#5157) * Validate before calculating checksum, move private functions at end in vm.go, add context to mockvm errors. * panic with errors. (cherry picked from commit 4bb8edd) # Conflicts: # modules/light-clients/08-wasm/types/vm.go * Fix conflicts. --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
couple of minor nits that were brought up.
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.