Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow to trigger wasm E2Es with a specific tag #5288

Merged
merged 13 commits into from
Nov 30, 2023

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Nov 30, 2023

Description


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@github-actions github-actions bot added the github_actions Pull requests that update Github_actions code label Nov 30, 2023
@@ -0,0 +1,38 @@
name: Manual WASM E2E (Simd)
on:
# when https://github.com/community/community/discussions/11795 is resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopium that github won't fire the team responsible for this :octocat:

Comment on lines +16 to +18
required: true
type: string
default: "ghcr.io/cosmos/ibc-go-wasm-simd"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropping your previous words of wisdom #3873 (comment)

we can clean these up all together though, they are elsewhere too

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@damiannolan damiannolan merged commit 701228d into main Nov 30, 2023
57 of 58 checks passed
@damiannolan damiannolan deleted the cian/damian/manual-wasm-workflow branch November 30, 2023 17:45
damiannolan added a commit that referenced this pull request Dec 5, 2023
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants