-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: reasoning and use cases for channel upgradability #5346
docs: reasoning and use cases for channel upgradability #5346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for picking up a bunch of the documentation issues, @charleenfei.
…asoning-and-use-cases-for-channel-upgradability
…asoning-and-use-cases-for-channel-upgradability
…asoning-and-use-cases-for-channel-upgradability
…asoning-and-use-cases-for-channel-upgradability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM 🚀
Left a couple of nits and suggestions on wording, feel free to apply which ones you want :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't have much to add reading previous reviews, looks great to me! 🎊
…asoning-and-use-cases-for-channel-upgradability
…channel-upgradability' of github.com:cosmos/ibc-go into charly/issue#5267-document-reasoning-and-use-cases-for-channel-upgradability
Description
closes: #5267
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.