Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: mark GetTimestamp as deprecated #5353

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Chore: mark GetTimestamp as deprecated #5353

merged 4 commits into from
Dec 11, 2023

Conversation

sontrinh16
Copy link
Member

@sontrinh16 sontrinh16 commented Dec 9, 2023 •
edited
Loading

Description

closes: #4220

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@sontrinh16 sontrinh16 marked this pull request as ready for review December 9, 2023 16:47
@sontrinh16 sontrinh16 changed the title mark GetTimestamp as deprecated Chore: mark GetTimestamp as deprecated Dec 11, 2023
colin-axner
colin-axner approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

DimitrisJim
DimitrisJim approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! 🥇

@crodriguezvega crodriguezvega merged commit b07010d into cosmos:main Dec 11, 2023
62 checks passed
This was referenced Mar 14, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-axner colin-axner colin-axner approved these changes

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@damiannolan damiannolan damiannolan approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@charleenfei charleenfei Awaiting requested review from charleenfei

@chatton chatton Awaiting requested review from chatton chatton is a code owner

@srdtrk srdtrk Awaiting requested review from srdtrk srdtrk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sontrinh16 @damiannolan @DimitrisJim @colin-axner @crodriguezvega