-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp: add passthrough handlers for callbacks mw module #5376
Merged
charleenfei
merged 13 commits into
04-channel-upgrades
from
charly/issue#4575-implement-the-channel-upgradability-application-callbacks-for-mod/callbacks
Dec 14, 2023
Merged
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2376567
add passthrough handlers for callbacks mw module
charleenfei 69f95db
rm unused var
charleenfei 5093acc
Merge branch '04-channel-upgrades' into charly/issue#4575-implement-t…
charleenfei 26de95f
Merge branch '04-channel-upgrades' into charly/issue#4575-implement-t…
charleenfei 72f9ded
update for cbs routing
charleenfei 176fe1d
lint
charleenfei 9d92010
Merge branch '04-channel-upgrades' into charly/issue#4575-implement-t…
charleenfei 73d5481
fix: implement full upgradable module interface
colin-axner 0665746
imp: add upgradable module assertion for 29-fee
colin-axner 117b6df
Merge branch '04-channel-upgrades' into charly/issue#4575-implement-t…
colin-axner ebc8199
Revert "imp: add upgradable module assertion for 29-fee"
colin-axner 61b8e93
make lint-fix
DimitrisJim 1d16e96
Merge branch '04-channel-upgrades' into charly/issue#4575-implement-t…
charleenfei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: these err messages seem slightly off structurally wise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how so? what would you expect them to look like?
I think this is how I structured them in the initial PR for core and other mods like fee etc, I'm open to suggestions if you want to open a PR and address all of them together after this then go ahead!