Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: wait for sync nodes before stopping in e2e upgrade tests #5408

Merged
merged 5 commits into from
Dec 14, 2023
Merged

chore: wait for sync nodes before stopping in e2e upgrade tests #5408

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ed72c19
chore: wait for sync nodes before stopping in e2e upgrade tests
damiannolan Dec 14, 2023
61e2fe9
chore: handle err returns from WaitForInSync
damiannolan Dec 14, 2023
329a2e5
Merge branch 'main' into damian/add-wait-for-sync-to-upgrade-e2es
DimitrisJim Dec 14, 2023
0cf624c
Merge branch 'main' into damian/add-wait-for-sync-to-upgrade-e2es
damiannolan Dec 14, 2023
1412eac
Merge branch 'main' into damian/add-wait-for-sync-to-upgrade-e2es
damiannolan Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions e2e/tests/upgrades/upgrade_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,13 @@ func (s *UpgradeTestSuite) UpgradeChain(ctx context.Context, chain *cosmos.Cosmo
err = test.WaitForBlocks(timeoutCtx, int(haltHeight-height)+1, chain)
s.Require().Error(err, "chain did not halt at halt height")

var allNodes []test.ChainHeighter
for _, node := range chain.Nodes() {
allNodes = append(allNodes, node)
}

test.WaitForInSync(ctx, chain, allNodes...)
damiannolan marked this conversation as resolved.
Show resolved Hide resolved

err = chain.StopAllNodes(ctx)
s.Require().NoError(err, "error stopping node(s)")

Expand Down
Loading