Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: fix wasm e2e tests #5416

Merged
merged 3 commits into from
Dec 14, 2023
Merged

e2e: fix wasm e2e tests #5416

merged 3 commits into from
Dec 14, 2023

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented Dec 14, 2023

Description

  • Add feature releases to fix recover client tests on v7.3
  • Add feature releases to fix failed reason not being propagated in v7.3

Tags are expected to built like this for now:

ghcr.io/cosmos/ibc-go-wasm-simd:v7.3.0-wasm
ghcr.io/cosmos/ibc-go-wasm-simd:v8.0.0-wasm

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@codecov-commenter
Copy link

Codecov Report

Merging #5416 (54ccd2a) into main (549fd90) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5416   +/-   ##
=======================================
  Coverage   80.07%   80.08%           
=======================================
  Files         189      189           
  Lines       13106    13142   +36     
=======================================
+ Hits        10495    10525   +30     
- Misses       2199     2203    +4     
- Partials      412      414    +2     

see 2 files with indirect coverage changes

@damiannolan damiannolan marked this pull request as ready for review December 14, 2023 12:40
@damiannolan damiannolan added the priority PRs that need prompt reviews label Dec 14, 2023
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, guys!

@damiannolan damiannolan merged commit 06501b0 into main Dec 14, 2023
73 of 74 checks passed
@damiannolan damiannolan deleted the damian/cian/fix-e2e-wasms branch December 14, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PRs that need prompt reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants