chore: ica submodules minor improvements and cleanup #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etAllPorts, move ValidateBasic check
damiannolan
requested review from
crodriguezvega,
seantking,
AdityaSripal,
charleenfei and
colin-axner
damiannolan
commented
Nov 18, 2021
| @@ -56,7 +56,7 @@ func (AppModuleBasic) DefaultGenesis(cdc codec.JSONCodec) json.RawMessage { | |||
|
|
|||
| // ValidateGenesis performs genesis state validation for the IBC interchain acounts module | |||
| func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, config client.TxEncodingConfig, bz json.RawMessage) error { | |||
| return nil | |||
| return nil // TODO: https://github.com/cosmos/ibc-go/issues/535 | |||
There was a problem hiding this comment.
I figured implementing ValidateGenesis should be kept to it's own PR entirely. Wanted to keep this concise.
seantking
reviewed
Nov 19, 2021
seantking
approved these changes
Nov 19, 2021
colin-axner
approved these changes
Nov 19, 2021
faddat
pushed a commit
to notional-labs/ibc-go
that referenced
this pull request
Feb 23, 2022
…hub.com/spf13/viper-1.8.1 Bump github.com/spf13/viper from 1.8.0 to 1.8.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following PR includes some residual follow up tasks from #541, namely:
(gogoproto.nullable) = falsein favour of pointer typesExportGenesisto include default genesis types in favour ofnilpointersGetAllPortsunused function fromhostsubmoduleValidateBasiccheck in relay.go to avoid unnecessary loop iterationscloses: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes