Add section about wiring up fee middleware and executing gov proposal #5504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
added
docs
chatton
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei,
damiannolan,
DimitrisJim and
srdtrk
as code owners
…xisting-transfer-channel
…xisting-transfer-channel
…xisting-transfer-channel
…xisting-transfer-channel
charleenfei
approved these changes
Jan 5, 2024
…xisting-transfer-channel
damiannolan
approved these changes
Jan 8, 2024
|
|
||
| ### Submit a governance proposal to execute a MsgChanUpgradeInit message | ||
|
|
||
| Only an authority is able to initiate a channel upgrade by submitting a `MsgChanUpgradeInit` message. |
There was a problem hiding this comment.
Suggested change
| Only an authority is able to initiate a channel upgrade by submitting a `MsgChanUpgradeInit` message. | |
| Only the configured authority for the ibc module is able to initiate a channel upgrade by submitting a `MsgChannelUpgradeInit` message. |
| ibcRouter.AddRoute(ibctransfertypes.ModuleName, transferStack) | ||
| ``` | ||
|
|
||
| ### Submit a governance proposal to execute a MsgChanUpgradeInit message |
There was a problem hiding this comment.
Suggested change
| ### Submit a governance proposal to execute a MsgChanUpgradeInit message | |
| ### Submit a governance proposal to execute a MsgChannelUpgradeInit message |
| @@ -164,3 +164,94 @@ IBC application callbacks should be primarily used to validate data fields and d | |||
| > IBC applications should not attempt to process any packet data under the new conditions until after `OnChanUpgradeOpen` | |||
| > has been executed, as up until this point it is still possible for the upgrade handshake to fail and for the channel | |||
| > to remain in the pre-upgraded state. | |||
|
|
|||
| ## Upgrade existing transfer stack to be fee enabled | |||
There was a problem hiding this comment.
Suggested change
| ## Upgrade existing transfer stack to be fee enabled | |
| ## Upgrade an existing transfer application stack to use 29-fee middleware |
| "fields": { | ||
| "ordering": "ORDER_UNORDERED", | ||
| "connection_hops": ["connection-0"], | ||
| "version": "{\"fee_version\":\"ics29-1\",\"app_version\":\"ics20-1\"}" |
There was a problem hiding this comment.
Should we add a note saying that changing the version is the important part?
DimitrisJim
approved these changes
Jan 8, 2024
chatton
deleted the
cian/issue#5273-add-tutorial-for-upgrading-existing-transfer-channel
branch
charleenfei
pushed a commit
that referenced
this pull request
Jan 11, 2024
charleenfei
pushed a commit
that referenced
this pull request
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #5273
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.