Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for MsgPruneAcknowledgement #5510

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Jan 3, 2024

Description

pending #5482

closes: #5501


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@crodriguezvega crodriguezvega added docs Improvements or additions to documentation channel-upgradability Channel upgradability feature labels Jan 8, 2024
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! are we fine with CLI being here as opposed to it being in a separate client.md as we do in other places? (Can't find where other CLI commands for core are documented tbh)

@chatton chatton marked this pull request as ready for review January 10, 2024 09:39
@chatton chatton enabled auto-merge (squash) January 10, 2024 09:40
@chatton chatton merged commit e7a2844 into main Jan 10, 2024
18 of 19 checks passed
@chatton chatton deleted the cian/issue#5501-document-pruning-acks branch January 10, 2024 09:45
charleenfei pushed a commit that referenced this pull request Jan 11, 2024
charleenfei pushed a commit that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channel-upgradability Channel upgradability feature docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document usage of message for pruning acknowledgements
4 participants