fix: add packet seq in success log #5559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this bug was introduced in cosmos@e93a467
mmsqe
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
DimitrisJim
approved these changes
Jan 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5559 +/- ##
=======================================
Coverage 81.19% 81.19%
=======================================
Files 197 197
Lines 15253 15253
=======================================
Hits 12384 12384
Misses 2404 2404
Partials 465 465
|
colin-axner
approved these changes
Jan 10, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
this bug was introduced in e93a467 Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> (cherry picked from commit 93f86fc) # Conflicts: # modules/apps/27-interchain-accounts/host/ibc_module.go # modules/apps/transfer/ibc_module.go
mergify bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
this bug was introduced in e93a467 Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> (cherry picked from commit 93f86fc) # Conflicts: # modules/apps/27-interchain-accounts/host/ibc_module.go # modules/apps/transfer/ibc_module.go
This was referenced Jan 10, 2024
charleenfei
pushed a commit
that referenced
this pull request
Jan 11, 2024
this bug was introduced in e93a467 Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
charleenfei
pushed a commit
that referenced
this pull request
Jan 11, 2024
this bug was introduced in e93a467 Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this bug was introduced in e93a467
Description
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.