Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E Upgrade test which performs a software upgrade and then a channel upgrade #5661

Merged
merged 18 commits into from
Jan 29, 2024

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Jan 18, 2024

Description

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good. I hope we can have a new relayer image soon to use it here!

e2e/tests/upgrades/upgrade_test.go Outdated Show resolved Hide resolved
e2e/tests/upgrades/upgrade_test.go Outdated Show resolved Hide resolved
e2e/tests/upgrades/upgrade_test.go Outdated Show resolved Hide resolved
# Conflicts:
#	e2e/tests/upgrades/upgrade_test.go
#	e2e/testsuite/testconfig.go
#	e2e/testvalues/values.go
@crodriguezvega crodriguezvega marked this pull request as ready for review January 27, 2024 13:12
@crodriguezvega crodriguezvega added channel-upgradability Channel upgradability feature priority PRs that need prompt reviews e2e labels Jan 27, 2024
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wahoo!!! 🎉 Thanks @chatton 🙌 and to the others who contributed on this pr 🙂

e2e/tests/upgrades/upgrade_test.go Outdated Show resolved Hide resolved
crodriguezvega and others added 2 commits January 29, 2024 14:17
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@crodriguezvega crodriguezvega merged commit 7e88167 into main Jan 29, 2024
115 checks passed
@crodriguezvega crodriguezvega deleted the cian/upgrade-test-for-channel-upgrades branch January 29, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channel-upgradability Channel upgradability feature e2e priority PRs that need prompt reviews
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants