fix: allow RecvPacket and WriteAcknowledgement when channel is FLUSHING or FLUSHCOMPLETE
#5668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
DimitrisJim
approved these changes
Jan 19, 2024
crodriguezvega
added
priority
9 tasks
charleenfei
approved these changes
Jan 22, 2024
chatton
approved these changes
Jan 22, 2024
colin-axner
suggested changes
Jan 22, 2024
crodriguezvega
changed the title
WriteAcknowledgement when channel is FLUSHINGRecvPacket and WriteAcknowledgement when channel is FLUSHING or FLUSHCOMPLETE
colin-axner
approved these changes
Jan 22, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
…LUSHING` or `FLUSHCOMPLETE` (#5668) * in write acknowledgement the channel state is allowed to be flushing as well * add test case * allow recv packet and write acknowledgement when state is also FLUSHCOMPLETE * fix tests --------- Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> (cherry picked from commit 91a1e8f)
crodriguezvega
added a commit
that referenced
this pull request
Jan 22, 2024
…LUSHING` or `FLUSHCOMPLETE` (#5668) (#5684) * in write acknowledgement the channel state is allowed to be flushing as well * add test case * allow recv packet and write acknowledgement when state is also FLUSHCOMPLETE * fix tests --------- Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> (cherry picked from commit 91a1e8f) Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While doing testing with hermes Luca an I found that hermes couldn't relay packets when the channel end was
FLUSHINGbecauseRecvPacketRPC handler failed onWriteAcknowledgement.closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.