Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove unnecessary getters on connection end #5777

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

colin-axner
Copy link
Contributor

Description

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@colin-axner colin-axner added the type: code hygiene Clean up code but without changing functionality or interfaces label Jan 31, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d330de7) 81.55% compared to head (4d70f38) 81.59%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5777      +/-   ##
==========================================
+ Coverage   81.55%   81.59%   +0.03%     
==========================================
  Files         199      199              
  Lines       15180    15167      -13     
==========================================
- Hits        12380    12375       -5     
+ Misses       2334     2326       -8     
  Partials      466      466              
Files Coverage Δ
...interchain-accounts/controller/keeper/handshake.go 83.70% <100.00%> (ø)
...ules/apps/27-interchain-accounts/types/metadata.go 79.79% <100.00%> (ø)
modules/core/03-connection/keeper/keeper.go 92.36% <100.00%> (ø)
modules/core/03-connection/keeper/verify.go 80.36% <100.00%> (ø)
modules/core/03-connection/types/codec.go 100.00% <ø> (ø)
modules/core/03-connection/types/connection.go 89.83% <ø> (+10.72%) ⬆️
modules/core/04-channel/keeper/handshake.go 90.20% <100.00%> (ø)
modules/core/04-channel/keeper/packet.go 99.09% <100.00%> (ø)
modules/core/04-channel/keeper/timeout.go 95.39% <100.00%> (ø)
modules/core/04-channel/keeper/upgrade.go 92.46% <100.00%> (ø)

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 🧹 🧹

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@colin-axner colin-axner merged commit 1c0c756 into main Jan 31, 2024
68 checks passed
@colin-axner colin-axner deleted the colin/rm-connection-getters branch January 31, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants