-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Addtional check against wrapped upgrade error in ChannelUpgradeTry
#5823
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5823 +/- ##
==========================================
+ Coverage 81.59% 81.61% +0.02%
==========================================
Files 199 198 -1
Lines 15167 12113 -3054
==========================================
- Hits 12375 9886 -2489
+ Misses 2326 1765 -561
+ Partials 466 462 -4
|
ChannelUpgradeTry
I think the fail test is coming from |
ChannelUpgradeTry
ChannelUpgradeTry
should be a flake, dont worry about it! let me re-launch them! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me; thanks, @hoangdv2429.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean solution! Thank you @hoangdv2429 🚀 ❤️🔥
Description
closes: #5737
This PR add addtional check in
ChannelUpgradeTry
incaseerr
is wrapped to avoid panic.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.